Skip to content

Commit

Permalink
Fix timeout in position-absolute-replaced-minmax.html (servo#34075)
Browse files Browse the repository at this point in the history
Some images don't load because we don't support SVG.
In that case this makes the test fail rather than timing out.

Signed-off-by: Oriol Brufau <[email protected]>
  • Loading branch information
Loirooriol authored Oct 30, 2024
1 parent cf66330 commit 62c7951
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 21 deletions.
2 changes: 1 addition & 1 deletion tests/wpt/meta/MANIFEST.json
Original file line number Diff line number Diff line change
Expand Up @@ -565360,7 +565360,7 @@
]
],
"position-absolute-replaced-minmax.html": [
"5a76277092bf9e84605fbb8e1fd64e17259e3f44",
"6e5c1f2be5340f027081f22a81dfb4796ab861c1",
[
null,
{}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,64 +1,63 @@
[position-absolute-replaced-minmax.html]
expected: TIMEOUT
[minmax replaced IFRAME 10]
expected: FAIL

[minmax replaced IFRAME 11]
expected: FAIL

[minmax replaced IMG svg 23]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG svg 24]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG svg 25]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG svg 26]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG svg 27]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG svg 28]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG svg 29]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG svg 30]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG svg 31]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG svg 32]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG svg 33]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG 34]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG 35]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG 36]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG 37]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG 38]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG 39]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG 40]
expected: NOTRUN
expected: FAIL

[minmax replaced IMG 41]
expected: NOTRUN
expected: FAIL
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@

function testAfterImageLoads(img, test) {
let asyncTest = async_test(getTestName(img));
img.addEventListener("error", asyncTest.unreached_func("Load shouldn't fail"));
img.addEventListener("load", _ => {
asyncTest.step(test);
asyncTest.done();
Expand Down

0 comments on commit 62c7951

Please sign in to comment.