Implement logging and additional exception handling #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renamed: johnnyfive/old_email.py -> ToyModels/old_email.py modified: johnnyfive/gmail.py modified: johnnyfive/utils.py
modified: johnnyfive/confluence.py modified: johnnyfive/gmail.py modified: johnnyfive/utils.py
tbowers7
force-pushed
the
api_changes
branch
5 times, most recently
from
47184a2 to
f4e8906
Compare
modified: johnnyfive/confluence.py modified: johnnyfive/gmail.py modified: johnnyfive/slack.py modified: johnnyfive/utils.py
tbowers7
force-pushed
the
api_changes
branch
from
f4e8906 to
0e08c43
Compare
modified: README.md modified: johnnyfive/gmail.py
The `pkg_resources` package is being deprecated in favor of `importlib` modules `resources` and `metadata`. This commit updates this package to be in line with this change. modified: johnnyfive/confluence.py modified: johnnyfive/gmail.py modified: johnnyfive/utils.py
In the case where a GMAIL message has multiple "parts" (i.e., HTML, images, etc.), the payload['body'] dictionary element is empty, and what would be there is as a list in the 'parts' element. In the simple case where the GMAIL message is text only, there is only one part (as is the case with relay DOL messages -- the test case when developing this class). This commit adds a check for the 'parts' dictionary element, and selects the first PART, if such a list exists. Otherwise, the usual behavior of extracting the payload['body'] dictionary element holds. This works with the hand-delivered DOL messages of the past few days (the mail relay is down due to IT issues), but no guarantee is made or implied that this fix will be appropriate or work in all use cases of this j5 class. modified: johnnyfive/gmail.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging implemented (rather than just print to screen), but will print to
stdoutif no logger passed in.Additional error catching for various situations seen during the routine running.
Documentation cleanup and some variable name changes for clarity.