This repository has been archived by the owner on Nov 20, 2020. It is now read-only.
Solaris Fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as provided by http://www.inf.puc-rio.br/~roberto/lpeg/ on 2016-05-26 `MD5 (lpeg-1.0.0.tar.gz) = 0aec64ccd13996202ad0c099e2877ece`
Solaris (OmniOS, Illumos) version of luajit does not support support
allocation of lightuserdata on the stack. This gives errors like this:
```
$ luajit test.lua
General tests for LPeg library
version 1.0.0
luajit: bad light userdata pointer
stack traceback:
[C]: in function 'match'
test.lua:58: in main chunk
[C]: at 0x00402d50
```
This commit patch fixes this behavior by moving the allocations to the
heap.
Original Author: Jonas Kunze.
| @@ -146,7 +147,7 @@ static int removedyncap (lua_State *L, Capture *capture, | |||
| */ | |||
| const char *match (lua_State *L, const char *o, const char *s, const char *e, | |||
| Instruction *op, Capture *capture, int ptop) { | |||
| Stack stackbase[INITBACK]; | |||
| Stack *stackbase = calloc(INITBACK, sizeof(Stack)); | |||
There was a problem hiding this comment.
No sanity check present in case of failure.
By using the assert macro the process will exit if calloc fails. There is little chance to recover from a failed allocation. Moreover assert() is used at other places already.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On operating systems like Solaris and Illumos where the stack grows down, lightuserdata and user data cannot be assigned from the stack. This commit patch fixes this behaviour by moving the allocations to the heap (using calloc).
We also ran into symbol collisions (
compile) when linking the library with our codebase. This is also addressed in a separate commit.