Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideology/DefInjected-9 #1334

Merged
merged 5 commits into from
Oct 27, 2021
Merged

Conversation

kamadz
Copy link
Contributor

@kamadz kamadz commented Oct 3, 2021

Close #1284 Ideology/DefInjected, part 9

Copy link
Contributor

@Elevator89 Elevator89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Первое полуревью готово. Второе будет завтра

<li>whoWasWereSeeking(beggarCount==1,beggar_gender==Female)->искавшая</li>
<li>whoWasWereSeeking(beggarCount>=2)->искавшие</li>
<li>wasWereBetrayed(beggarCount==1)->был предан</li>
<li>wasWereBetrayed(beggarCount==1,beggar_gender==Female)->была предана</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beggar_gender - нет такой переменной. Попробуй beggars0_gender.

Comment on lines 20 to 27
<li>wasWereBetrayed(beggarCount==1)->был предан</li>
<li>wasWereBetrayed(beggarCount==1,beggar_gender==Female)->была предана</li>
<li>wasWereBetrayed(beggarCount>=2)->были преданы</li>
<li>groupLabelSingleOrPlural(beggarCount==1)->путешественник</li>
<li>groupLabelSingleOrPlural(beggarCount==1)->путешественница</li>
<li>groupLabelSingleOrPlural(beggarCount>=2)->путешественники</li>
</Beggars.questContentRules.rulesStrings>
<!-- EN:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Форматирование пляшет

Ideology/DefInjected/QuestScriptDef/Script_Beggars.xml Outdated Show resolved Hide resolved
Ideology/DefInjected/QuestScriptDef/Script_Beggars.xml Outdated Show resolved Hide resolved
Ideology/DefInjected/QuestScriptDef/Script_Beggars.xml Outdated Show resolved Hide resolved
Ideology/DefInjected/QuestScriptDef/Script_Beggars.xml Outdated Show resolved Hide resolved
Ideology/DefInjected/QuestScriptDef/Script_Beggars.xml Outdated Show resolved Hide resolved
<li>takeoverPawnsPlural(factionless==false)->[roughOutlander_pawnsPlural]</li>
<li>takeoverPawnsPlural(factionless==true)->[wildPeople]</li>
<li>wildPeople->дикари</li>
<li>wildPeopleAcc->дикарей</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выше требуется родительный, а не винительный падеж

<li>questName->the archonexus</li>
-->
<EndGame_ArchonexusVictory_SecondCycle.questNameRules.rulesStrings>
<li>questName->the archonexus</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

зе архонексус

kamadz and others added 2 commits October 11, 2021 01:22
Partial correction

Co-authored-by: Andrey Lemin <[email protected]>
@Elevator89 Elevator89 merged commit 9606672 into Ludeon:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ideology/DefInjected, part 9
2 participants