Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperparameter optimization #196

Merged
merged 16 commits into from
Jul 5, 2021
Merged

Hyperparameter optimization #196

merged 16 commits into from
Jul 5, 2021

Conversation

Luke-Poeppel
Copy link
Owner

@Luke-Poeppel Luke-Poeppel commented Jul 4, 2021

Some Sunday TODOs...
Fixes #195 (umbrella).

  • Re-run CF3D on composition set (try <0.8, 0.1, 0.1>). Does it still converge to 100%? (Yes 😄)
  • Change default cost function to 3DCF
  • Re-add SLSQP script.
  • Clean up plotting scripts. Decide on plots for Transcription vs. Composition accuracy (together or separate).

Sub-Issues:

@Luke-Poeppel
Copy link
Owner Author

Luke-Poeppel commented Jul 4, 2021

Accuracy up to 76.63% for the transcriptions (200/261)!

@Luke-Poeppel
Copy link
Owner Author

Using <0.8, 0.1, 0.1>, we still get 100% on the encoded works. Note: subdivision has to be enabled for the compositions. There's a lot of repeated code, though, which I'd like to simplify eventually.

sept_haikai_0
[21, 21]
sept_haikai_1
[21, 21]
liturgie
[29, 29]
livre_dorgue_0
[50, 50]
livre_dorgue_1
[15, 15]
(136, 136, 1.0)

@Luke-Poeppel
Copy link
Owner Author

Luke-Poeppel commented Jul 5, 2021

Finer grid search shows:

[0.81, 0.1, 0.09]
100%|████████████████████████████████████████████| 103/103 [00:15<00:00,  6.62it/s]
100%|████████████████████████████████████████████████| 5/5 [00:21<00:00,  4.29s/it]

([0.81, 0.1, 0.09], '->', [334, 397])
[0.81, 0.11, 0.08]
100%|████████████████████████████████████████████| 103/103 [00:15<00:00,  6.65it/s]
100%|████████████████████████████████████████████████| 5/5 [00:21<00:00,  4.27s/it]
([0.81, 0.11, 0.08], '->', [337, 397])

84.89% across datasets. Using [0.81, 0.1, 0.09].

@Luke-Poeppel
Copy link
Owner Author

Luke-Poeppel commented Jul 5, 2021

Remaining issues:

  • There's still an onset range bug with split_extractions. See the series of Proceleusmatic in SF1.
  • I added a condition to ensure any remaining sinks that aren't in the path (but still can be) are chosen. But SF1 ignores a viable trochee at the end.
  • It seems like Tribrachs are getting consistently ignored... Probably good idea to add Ditribrach for consitency. Might solve some of this.

@Luke-Poeppel Luke-Poeppel merged commit 986fd1a into dev Jul 5, 2021
@Luke-Poeppel Luke-Poeppel changed the title WIP: Hyperparameter optimization Hyperparameter optimization Jul 5, 2021
@Luke-Poeppel Luke-Poeppel deleted the hyperparameter_optimization branch July 5, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant