Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two step commit #5

Open
wants to merge 43 commits into
base: lumoz/develop
Choose a base branch
from
Open

Two step commit #5

wants to merge 43 commits into from

Conversation

yiweichi
Copy link

@yiweichi yiweichi commented Nov 4, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
Add relayer two step commit feature. Mainly involved with the file lumoz-scroll/rollup/internal/controller/relayer/l2_relayer.go.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@Marius-BC-Dev
Copy link
Collaborator

Can OnlyProver be removed? Because it's open-ended

@Marius-BC-Dev
Copy link
Collaborator

commitBatch needs to control that a block on L1 contains only one batch transaction.

@Marius-BC-Dev
Copy link
Collaborator

Variables need to be initialized, check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants