Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1221 #1222

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Fixes #1221 #1222

merged 1 commit into from
Feb 11, 2022

Conversation

nagmat84
Copy link
Collaborator

The CLI command sync was subject to a left-over numeric album ID.

@nagmat84 nagmat84 requested review from ildyria and kamil4 February 11, 2022 16:02
@nagmat84 nagmat84 linked an issue Feb 11, 2022 that may be closed by this pull request
Import through CLI to user's root without specifying album #1221
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #1222 (f57083b) into master (7f99804) will decrease coverage by 0.93%.
The diff coverage is n/a.

ildyria
ildyria approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kamil4
kamil4 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@nagmat84 nagmat84 merged commit e0c2c8c into master Feb 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_1221 branch February 11, 2022 16:42
@anoteng anoteng mentioned this pull request Feb 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil4 kamil4 kamil4 approved these changes

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import through CLI to user's root without specifying album
3 participants
@nagmat84 @ildyria @kamil4