-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure run_on_url #23
Conversation
Merge HEAD from origin repo
Updated forked Repo
This should close #18 |
Delete vectors.txt.bak
Thanks Chase! This looks really good. One equestion. Have you tested it at all on something like xss-game? You can find the example link in the menu startup. |
I've tested this and as I mentioned this does not FIX the already present problems (see #21). It does not however add any other problems. I've a working version right now but I have not pushed it because I wanna do this one by one. Also I need to know how diff is being used before I can make a working change, I can only make it work without diff for now. See, diff is quite flawed..... It returns true if the sources are same, not different. Which is fine I guess, except- It's being used to check whether they are different, as in this if statement supposedly wants I'll push the working versions right today but I must make a request, allow me to suspend this |
Yes for sure, feel free to suspend the diff module. Its not working correctly it seems anyways. |
This is a working version of the program.
Alright, I merged a working version to this PR. Here's the things I've changed -
Every payload comes with a newline already with it (as I checked from debug). Hence that A disclaimer on it's current state of working, this is for the payloads that work perfectly- However, there are a bunch of payloads that either have syntax error or some other error in them. I suggest you check these out - We can merge this build right now though. I'll be working on improving the HTML scan now, creating a webelement_list everytime inside a loop isn't very effective anyway. Also check out the code in |
Merging, looks good! Thanks for the contribution. The URL variable is the straight URL passed in. I did this so that if they have cookies it will render the normal webpage that they'd request and then add the cookies to that. |
This PR separates many of the tasks in
run_on_url
(inside Scanner.py) to be a function of their own. It also implements a few common functions that the code can use instead of having multiple instances of the same snippet. (e.gfinal_report
,count_results
).The function
store_results
(Not created by me) has also been called insidefinal_report
. It was not being used before. So I sure hope it works correctly.Note : This PR does not change/fix/improve anything except code readability. There are still bugs/unhandled exceptions that exist. I see a lot of flaws in the
diff
implementation, especially when alerts are not being addressed. The PR to fix these will be seperate.