Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed jupyter and ipywidgets from Dependencies #68

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

guillaume-vignal
Copy link
Collaborator

Fixes: #67

Description

This PR removes unnecessary dependencies, namely jupyter and ipywidgets, from the pyproject.toml file. These dependencies were not required for core functionality and could lead to unnecessary bloat in environments where these tools are not needed.

Key Changes:

  • Removed Unnecessary Dependencies:
    • The following packages were removed from the dependencies section in pyproject.toml:
dependencies = [
                "pandas>=2",
                "catboost>=1.0.1",
                "panel>=1.4.1",
                "jinja2>=2.11.0",
                "scipy>=1.4.0",
                "seaborn>=0.10.1",
                "shapash>=2.0.0",
                "plotly",
                # Removed unnecessary dependencies
                # "jupyter",
                # "ipywidgets",
             ]

Benefits:

  • Reduced Environment Size: By removing these unnecessary packages, the overall environment becomes lighter and faster to install.
  • Improved Setup Time: With fewer dependencies to install, the setup process will be faster, particularly for CI pipelines and production environments.
  • Increased Flexibility: The project becomes more portable and flexible, as it does not impose notebook-related dependencies on all environments.

@guillaume-vignal guillaume-vignal added the enhancement New feature or request label Oct 4, 2024
@guillaume-vignal guillaume-vignal self-assigned this Oct 4, 2024
@guillaume-vignal guillaume-vignal merged commit 6fed91f into master Oct 4, 2024
8 checks passed
@guillaume-vignal guillaume-vignal deleted the feature/dependencies_removal branch October 4, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary Package Dependencies
2 participants