Optimize get_bool_input and get_bool_side #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gth buckets add up to 255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to https://github.com/BramOtte/MCHPRS/tree/optimize-boolean-edges-2
this change optimizes for the fact that most components don't care about signal strength but only about on or off.
But this optimization is much simpler and does not skip out on updates but simply makes them slightly faster.
This means the gains are likely smaller but the likelihood of this breaking anything is very small.
This optimization results in about a 6% rtps increase when running the Iris Mandelbrot program.
Tested on ubuntu 20.04 on an Intel core i7-10750H over multiple runs