Add Pretendo Support #28
Conversation
… pretendo (thanks DaniElectra on discord)
…ybe to active users)
…network you are on later)
It seems to be functioning after adding a horrifying fix, to make NintendoClients send ACK after 3170 years. This isn't permanent, but it should be fine till Pretendo fixes the bug that breaks this the code without this hack. So I'm gonna say, unless I find any other app-breaking issues, it should be fine to merge! (finally!) |
|
never... mind... it's hanging again nooooooooooooooooo! Edit 1: My hack is working again???? wha???? |
|
Hope this PR getting reviewed. Nintendo network is shut down. |
|
@MCMi460 please merge, most people won't be on Nintendo server because no online games work with it |
|
It looks like the bug that has been breaking this has been fixed, but Pretendo seems to be having some server issues still that affect this a bit, but shouldn't impact usage of this that much |
|
Soooo, any idea of when will this be merged? |
In general, it's not polite to ask for an exact date - open source maintainers have their lives to handle, on top of the work of maintaining and developing projects :) However, within the NSO-RPC Discord server, @MCMi460 stated they would like to begin reviewing this within the coming weeks. |
Sorry if it sounded rude, just wanted to know about any update on the project so far, thx for replying!! |
|
One quick question (I am not sure how PRs work really). If this PR got approved, why is it still open? |
Once a pull request is tested against the codebase it's supposed to merge with, it can be approved as functional, but still needs to actually be pushed into the codebase by a developer with that level of permissions (which are fairly few and far between in most projects) |
|
Thanks! I'm not that experienced with how GitHub works. |
It is also technically merged (see 8751376), but it was merged pretty poorly, missing some lines. So i really don't know why it's open |
|
It'll most likely get closed when Pretendo support is working and live. |
|
@Preloading does that mean it should work then? |
|
really hyped for this!! |
| if network == 1: # If the app starts randomly hanging on Pretendo, try removing this, and the next line. | ||
| s["prudp.ping_timeout"] = 100000000000 # oh my god this is horrifying, but it makes it works, so who am i to care |
There was a problem hiding this comment.
We made a lot of stability changes and bug fixes a while ago, after this PR was made. This hack can likely be removed, and if the issue still persists then you should open an issue about it on our end. This is obviously bad behavior on our end if it persists
There was a problem hiding this comment.
Hi there! A bit ago, I tested, and the program does work without these lines. (yay, thank you!) However, the PR has technically been merged (see 8751376), so I can't modify the PR without causing problems (probably). Why this isn't closed, I do not know. I should probably close it. I'll make sure to try to get the owner of the repo to remove the workaround. Thanks tho!
|
Squashed and merged in commit 8751376 |
This is a pretty massive PR, that should (mostly) add Pretendo support. This should resolve #10 and it should resolve #23. I am so so so glad that this mostly done.
Some other modifications:
I probably broke the client, I tried to make it work, but it seemed to inconvenient to set it up, and after someone said it was deprecated, I decided not to test. I believe that it will probably be deprecated, as the web app is much more convenient and easier to useEdit: Decided to test and fixed everything broken with it. Works with nintendo only though.Migration Steps
Since this is a pretty massive update, it does require some database changes. I created a handy migration SQL file. MAKE SURE TO BACKUP THE DATABASE BEFORE RUNNING THE FILE!!!, you can't easily revert this, so make sure you have a backup in case if something goes wrong. This should prepare the database for pretendo, but to get it to actually run the pretendo backend, you must use your sacrificial 3ds again, and redump the NEX keys, this time in pretendo mode (you can get into pretendo mode by using Nimbus) You will also need to modify your private.py and public.py according to template.private.py & public.py. You will also need to modify whatever you use to start the backend, to start it twice at the same time with the arguments:
python backend.py -n nintendopython backend.py -n pretendoor
python backend.py --network nintendopython backend.py --network pretendowhichever is most convenient for you. This should be enough for you to have both Pretendo & Nintendo running! If it's not for some reason, please either comment on this post, or message me on discord (@Preloading)
Oh also, I recommend you do a test of it first, as I do not have the ablility to add activities.write to my thing, so I have no clue whether discord.py works.
Image Gallery
Because I'm proud of doing this
VERY BIG NOTEThis isn't quite functional yet, due to a presumed bug in Pretendo, where NintendoClients hangs the script. I've gotten it to mostly work, to the point of testing for a short period, but it will hang if left running.Also Jon, in issue #10, it was not as simple as swapping out the url D: (also thank you for the effort you put in pretendo team. Not only did you deal with my stupid questions, and fixing some sorta date time bug which made the code not work, and eventually the bug which prevents this from being finished, thank you for creating and hosting pretendo!)