Remove packr and use go:embed #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we copy the mixin schema into the helm3 mixin binary, previously we used the packr library. Now that Go 1.16 supports embedding files into a binary, we don't need to use it anymore (its difficult to build properly). I have updated helm3 to use go:embed for the schema and fixed some broken unit tests. Signed-off-by: Carolyn Van Slyck <[email protected]>
|
Thank you @carolynvs for the fix. I tried the draft and it works in my end |
|
Thanks for checking, I don't know what is causing all my problems with VS Code lately. I think I need to do a clean install. 🔥 |
MChorfa
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we copy the mixin schema into the helm3 mixin binary, previously we used the packr library. Now that Go 1.16 supports embedding files into a binary, we don't need to use it anymore (its difficult to build properly).
I have updated helm3 to use go:embed for the schema and fixed some broken unit tests.
I haven't been able to test this locally with my VS Code because there's a bug I'm running into getporter/vscode-extension#48. I'm going to try later tonight on a different computer.