Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed incorrect duecredit environment variable in documentation #4226

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

ianmkenney
Copy link
Contributor

@ianmkenney ianmkenney commented Aug 8, 2023

Changes made in this Pull Request:

  • Changed example duecredit environment variable from
    DUECREDIT-ENABLE (invalid) to DUECREDIT_ENABLE

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4226.org.readthedocs.build/en/4226/

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Linter Bot Results:

Hi @ianmkenney! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (2bf55dd) 93.62% compared to head (d733ed2) 93.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4226      +/-   ##
===========================================
- Coverage    93.62%   93.62%   -0.01%     
===========================================
  Files          193      193              
  Lines        25295    25294       -1     
  Branches      4063     4063              
===========================================
- Hits         23683    23682       -1     
  Misses        1096     1096              
  Partials       516      516              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing

@ianmkenney ianmkenney merged commit d33cc3a into MDAnalysis:develop Aug 9, 2023
21 of 25 checks passed
@ianmkenney ianmkenney deleted the duecredit branch August 9, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants