Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD end of August] Deal with loss of free continuous Cirrus CI #4234

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Aug 12, 2023

Fixes #4216

Changes made in this Pull Request:

  • Drop running Cirrus CI on PRs, now will only run on a twice weekly cron
  • Add badge so we know if things are breaking

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4234.org.readthedocs.build/en/4234/

@github-actions
Copy link

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6e80c28) 93.62% compared to head (8b91638) 93.62%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4234   +/-   ##
========================================
  Coverage    93.62%   93.62%           
========================================
  Files          193      193           
  Lines        25304    25304           
  Branches      4064     4064           
========================================
  Hits         23692    23692           
  Misses        1096     1096           
  Partials       516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the CI/CD work @IAlibay!

Comment on lines 19 to 20
print(env.get("CIRRUS_PR") != None)
print(env.get("CIRRUS_BASE_BRANCH") == "develop")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(env.get("CIRRUS_PR") != None)
print(env.get("CIRRUS_BASE_BRANCH") == "develop")
print(env.get("CIRRUS_PR") == None)
print(env.get("CIRRUS_BRANCH") == "develop")

Maybe worth changing this debug print?

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Presumably, the cron job won't run out of free minutes?

From what it sounded in discussions elsewhere, there's not much we can do about this right now apart from paying for these runners.

@IAlibay
Copy link
Member Author

IAlibay commented Aug 14, 2023

Thanks. Presumably, the cron job won't run out of free minutes?

From what it sounded in discussions elsewhere, there's not much we can do about this right now apart from paying for these runners.

I did a back of the envelope calculation in #4216 - we should be fine but we'll need to check exactly how many tokens are used up in a release.

@IAlibay IAlibay merged commit d8107b6 into develop Aug 28, 2023
24 checks passed
@IAlibay IAlibay deleted the bye-cirrus branch August 28, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT, CI: Cirrus resource usage changes coming September 1st
3 participants