-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD end of August] Deal with loss of free continuous Cirrus CI #4234
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4234 +/- ##
========================================
Coverage 93.62% 93.62%
========================================
Files 193 193
Lines 25304 25304
Branches 4064 4064
========================================
Hits 23692 23692
Misses 1096 1096
Partials 516 516 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the CI/CD work @IAlibay!
print(env.get("CIRRUS_PR") != None) | ||
print(env.get("CIRRUS_BASE_BRANCH") == "develop") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print(env.get("CIRRUS_PR") != None) | |
print(env.get("CIRRUS_BASE_BRANCH") == "develop") | |
print(env.get("CIRRUS_PR") == None) | |
print(env.get("CIRRUS_BRANCH") == "develop") |
Maybe worth changing this debug print?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Presumably, the cron job won't run out of free minutes?
From what it sounded in discussions elsewhere, there's not much we can do about this right now apart from paying for these runners.
I did a back of the envelope calculation in #4216 - we should be fine but we'll need to check exactly how many tokens are used up in a release. |
Fixes #4216
Changes made in this Pull Request:
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4234.org.readthedocs.build/en/4234/