Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 2.7.0] Fix deployment tests #4244

Merged
merged 4 commits into from
Aug 17, 2023
Merged

[HOLD 2.7.0] Fix deployment tests #4244

merged 4 commits into from
Aug 17, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Aug 15, 2023

Changes made in this Pull Request:

  • Add misssing packaging dependency
  • Remove some test exclusions for full deps tests.

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4244.org.readthedocs.build/en/4244/

We need it to get the version number in minimum deps builds.
@IAlibay
Copy link
Member Author

IAlibay commented Aug 15, 2023

If tests come back green from just changes to deploy.yaml then we can go ahead with the 2.6.0 release (we can just merge this into 2.7.0).

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (a603475) 93.40% compared to head (d170553) 93.41%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4244      +/-   ##
===========================================
+ Coverage    93.40%   93.41%   +0.01%     
===========================================
  Files          169      183      +14     
  Lines        22201    23306    +1105     
  Branches      4064     4064              
===========================================
+ Hits         20737    21772    +1035     
- Misses         948     1018      +70     
  Partials       516      516              

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Aug 15, 2023

If tests come back green from just changes to deploy.yaml then we can go ahead with the 2.6.0 release (we can just merge this into 2.7.0).

Ok we should be good, the main issue here was that micromamba no longer has packaging as a base dependency, so it unexpectedly bit us, all tests seem to be fine.

@IAlibay IAlibay changed the title Add packaging to micromamba setup [HOLD 2.7.0] Fix deployment tests Aug 15, 2023
Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all tests seem to pass as you say.

@IAlibay IAlibay merged commit 9032eb0 into develop Aug 17, 2023
23 checks passed
@RMeli RMeli deleted the fix-deploy branch August 18, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants