-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD 2.7.0] Fix deployment tests #4244
Conversation
We need it to get the version number in minimum deps builds.
If tests come back green from just changes to deploy.yaml then we can go ahead with the 2.6.0 release (we can just merge this into 2.7.0). |
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4244 +/- ##
===========================================
+ Coverage 93.40% 93.41% +0.01%
===========================================
Files 169 183 +14
Lines 22201 23306 +1105
Branches 4064 4064
===========================================
+ Hits 20737 21772 +1035
- Misses 948 1018 +70
Partials 516 516 ☔ View full report in Codecov by Sentry. |
Ok we should be good, the main issue here was that micromamba no longer has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all tests seem to pass as you say.
Changes made in this Pull Request:
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4244.org.readthedocs.build/en/4244/