Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix numpy dev0 install in nightly wheels #4383

Closed
wants to merge 7 commits into from
Closed

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Dec 23, 2023

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4383.org.readthedocs.build/en/4383/

Copy link

github-actions bot commented Dec 23, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edda942) 93.41% compared to head (7af23d8) 93.41%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4383     +/-   ##
==========================================
  Coverage    93.41%   93.41%             
==========================================
  Files          171      185     +14     
  Lines        22511    23625   +1114     
  Branches      4129     4129             
==========================================
+ Hits         21028    22069   +1041     
- Misses         963     1036     +73     
  Partials       520      520             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay marked this pull request as ready for review December 25, 2023 20:37
@IAlibay
Copy link
Member Author

IAlibay commented Dec 25, 2023

Let's see how CI looks, but I believe this should be good now. I swapped the order around in the hope that mamba would be more efficient at recognising the pre-installed (via pip) modules.

Actually on second thought, maybe the old approach was better so we could know if the dev0 build isn't picked up.

From the output of pip & mamba list it seems to be good.

@IAlibay IAlibay marked this pull request as draft December 25, 2023 20:41
@IAlibay
Copy link
Member Author

IAlibay commented Apr 28, 2024

Supplemented by #4502

@IAlibay IAlibay closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant