Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start 2.8.0-dev0 #4395

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Start 2.8.0-dev0 #4395

merged 2 commits into from
Dec 27, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Dec 26, 2023

Towards #4382

Changes made in this Pull Request:

  • Update changelog
  • Update relevant version entries
  • Remove numpy pin

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4395.org.readthedocs.build/en/4395/

Copy link

github-actions bot commented Dec 26, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@IAlibay
Copy link
Member Author

IAlibay commented Dec 26, 2023

🤦🏽‍♂️ somehow branch protection wasn't on... 5068a1e

Because this is a commit we would have merged here anyways, @fiona-naughton and I agreed that we will proceed with merging this.

Copy link
Contributor

@fiona-naughton fiona-naughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5068a1e) 93.41% compared to head (a3809d2) 93.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4395     +/-   ##
==========================================
  Coverage    93.41%   93.41%             
==========================================
  Files          171      185     +14     
  Lines        22511    23625   +1114     
  Branches      4129     4129             
==========================================
+ Hits         21028    22069   +1041     
- Misses         963     1036     +73     
  Partials       520      520             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Dec 27, 2023

failure is expected, merging.

@IAlibay IAlibay merged commit 2cae659 into develop Dec 27, 2023
22 of 23 checks passed
@IAlibay IAlibay deleted the start-2.8.0 branch December 27, 2023 00:03
ljwoods2 pushed a commit to ljwoods2/mdanalysis that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants