Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PEP518] Improve testsuite packaging #4463

Merged
merged 8 commits into from
Feb 23, 2024
Merged

[PEP518] Improve testsuite packaging #4463

merged 8 commits into from
Feb 23, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Feb 21, 2024

Changes made in this Pull Request:

  • Adds pyproject.toml to testsuite
  • Clears up ambigous packaging
  • Keeps setup.py for dynamic things only
  • Update license file
  • Update links info
  • Update some setup.py docstring text
  • Adds various missing init files

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4463.org.readthedocs.build/en/4463/

@pep8speaks
Copy link

pep8speaks commented Feb 21, 2024

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 83:29: E261 at least two spaces before inline comment

Comment last updated at 2024-02-23 07:10:18 UTC

Copy link

github-actions bot commented Feb 21, 2024

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.37%. Comparing base (2192fbb) to head (7b69052).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4463      +/-   ##
===========================================
- Coverage    93.38%   93.37%   -0.01%     
===========================================
  Files          171      183      +12     
  Lines        21744    22822    +1078     
  Branches      4014     4014              
===========================================
+ Hits         20305    21310    +1005     
- Misses         952     1025      +73     
  Partials       487      487              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

IAlibay added a commit that referenced this pull request Feb 22, 2024
@RMeli RMeli mentioned this pull request Feb 22, 2024
5 tasks
package/pyproject.toml Outdated Show resolved Hide resolved
package/pyproject.toml Outdated Show resolved Hide resolved
testsuite/MDAnalysisTests/parallelism/__init__.py Outdated Show resolved Hide resolved
testsuite/pyproject.toml Show resolved Hide resolved
testsuite/setup.py Show resolved Hide resolved
@IAlibay IAlibay requested a review from RMeli February 23, 2024 02:06
@IAlibay
Copy link
Member Author

IAlibay commented Feb 23, 2024

Thanks for the review @RMeli - I think I've addressed most comments, the social media stuff might need more discussion. I'm of the opinion that the pyproject.toml url links barely get used so we could probably just not think about them too much.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Irfan, LGTM

@IAlibay IAlibay merged commit 3a5339c into develop Feb 23, 2024
20 of 24 checks passed
@IAlibay IAlibay deleted the testsuite-pep518 branch February 23, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants