Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] fix versionchanged display in LAMMPS DumpReader #4720

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Sep 27, 2024

Changes made in this Pull Request:

  • fix: versionchanged was not displayed correctly in coordinates.LAMMPS.DumpReader

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4720.org.readthedocs.build/en/4720/

fix: versionchanged was not displayed correctly in coordinates.LAMMPS.DumpReader
@orbeckst orbeckst changed the title [doc] fix versionchanged display in LAMMPS DumpsReader [doc] fix versionchanged display in LAMMPS DumpReader Sep 27, 2024
Copy link

Linter Bot Results:

Hi @orbeckst! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ✅ Passed

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/11076749854/job/30780505548


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (84ee67b) to head (9840385).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4720      +/-   ##
===========================================
- Coverage    93.55%   93.53%   -0.02%     
===========================================
  Files          173      185      +12     
  Lines        21451    22517    +1066     
  Branches      3985     3985              
===========================================
+ Hits         20068    21061     +993     
- Misses         929     1002      +73     
  Partials       454      454              
Flag Coverage Δ
93.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It now shows up correctly on the rendered documentation.

@RMeli RMeli merged commit 78edac0 into develop Sep 28, 2024
24 of 25 checks passed
@RMeli RMeli deleted the docfix-lammps-dumpreader branch September 28, 2024 20:39
RMeli pushed a commit to RMeli/mdanalysis that referenced this pull request Oct 3, 2024
fix: versionchanged was not displayed correctly in coordinates.LAMMPS.DumpReader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants