Switch guessers to catching and raising NoDataErrors

[lilyminium]

Fixes #4749 (maybe?)

Changes made in this Pull Request:

• Switches errors to NoDataErrors

PR Checklist

• Tests?
• Docs?
• CHANGELOG updated?
• Issue raised/referenced?

Developers certificate of origin

• I certify that this contribution is covered by the LGPLv2.1+ license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

---

📚 Documentation preview 📚: https://mdanalysis--4755.org.readthedocs.build/en/4755/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (101008b) to head (52adce9).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4755      +/-   ##
===========================================
- Coverage    93.65%   93.62%   -0.03%     
===========================================
  Files          175      187      +12     
  Lines        21564    22631    +1067     
  Branches      3023     3023              
===========================================
+ Hits         20195    21189     +994     
- Misses         925      998      +73     
  Partials       444      444              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[orbeckst]

From reading the issue and glancing at the code, changing the raised ValueError to NoDataError makes sense and seems more consistent.

I am not really familiar with the new guesser code so this is just a surface-level review. Other reviews would be great.

@lilyminium I'll leave it to you to gather more opinions if you need them.

[lilyminium]

@IAlibay could you please have a look to see if this resolves issue #4749?