Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve Full Trajectory Information in AnalysisBase #4892

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

yuxuanzhuang
Copy link
Contributor

@yuxuanzhuang yuxuanzhuang commented Jan 14, 2025

Fixes #4891

Changes made in this Pull Request:

  • Add self._global_slicer to retrieve global details such as the total number of frames.
  • Add self._global_frame_index for _single_frame to track the global frame index for each frame

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4892.org.readthedocs.build/en/4892/

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (6842fd7) to head (2c9982b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4892      +/-   ##
===========================================
- Coverage    93.65%   93.63%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21795    22863    +1068     
  Branches      3067     3067              
===========================================
+ Hits         20413    21408     +995     
- Misses         931     1004      +73     
  Partials       451      451              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Jan 14, 2025

Hello @yuxuanzhuang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2025-01-14 18:49:12 UTC

@yuxuanzhuang
Copy link
Contributor Author

I’m not certain that _global_xxx is the most suitable naming convention for these attributes. I’d appreciate any alternative suggestions you might have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve Full Trajectory Information in Parallel Analysis
2 participants