-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Derive masks to support native-space data #24
base: main
Are you sure you want to change the base?
Conversation
Thank you @tsalo ! I tried running the integration tests and it fails. I think it's related to |
I didn't get any errors in the workflow itself, but it looks like the masks are different enough that the ICA produces different components, which is causing the test to fail. |
You guys mean locally right? Because the integration tests on Circle don't seem to have ever worked, correct? |
Right. The integration tests are going to fail on CircleCI until we get rid of FSL completely- unless we set up a Dockerfile with FSL installed, which we haven't done because we ultimately want to drop the dependency anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea. Please check #29 which will make these kinds of refactors easier to check for regressions
Co-authored-by: Oscar Esteban <[email protected]>
That's a weird error you got here. Is it somehow related to nilearn's |
References #2 and stems from Brainhack-Donostia/ica-aroma-org#49.
Changes proposed in this pull request: