Add MESMER-M integration tests #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Thanks - can you save the coeffs as netCDF and not pickle (I know it's a bit more annoying but we want to move away from pickle) |
veni-vidi-vici-dormivi
force-pushed
the
m_integrationtests
branch
from
17afff8 to
f97ea6e
Compare
for more information, see https://pre-commit.ci
|
I haven't looked into it so not sure what is going on but a bit strange that none of the environments get it right. I thought this does not have to be high priority but then it would be good to stabilize the numerics for memser-m. What helped for the covariance thingy was testing the code on cfc vs exo, which have different cpus with different sets of SIMD instructions. But I am not really working today - if I find time I'll take a look tomorrow or else after our retreat... |
mathause
reviewed
Nov 29, 2024
mathause
reviewed
Nov 29, 2024
|
good way to avoid pulling 😆 |
|
🥲 |
|
I think I should have adjusted |
mathause
reviewed
Dec 2, 2024
|
😅 |
mathause
approved these changes
Dec 2, 2024
for more information, see https://pre-commit.ci
veni-vidi-vici-dormivi
added a commit
to veni-vidi-vici-dormivi/mesmer
that referenced
this pull request
Dec 12, 2024
* add mesmer_m calibration test * add time to calibration results * update calibrate test * add test for drawing * update emulations * sneakily add nits to other tests * switch do allclose for drawing * switch to allclose for calibrating * nit in example * save params as netcdf * relax tol * test all params individually * test_calibrate_mesmer_m: mark slow * test_calibrate_mesmer_m: less localisation radii * extract data loading function * speed up by avoiding open_mfdataset * upper bound to lambda in pt * regenerate params * hm_coeffs: tighten atol & rtol * comment on upper bound * change order of yearly, monthly inputs for consistency * adjust example --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Victoria Bauer <[email protected]> Co-authored-by: Mathias Hauser <[email protected]> Co-authored-by: Mathias Hauser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.rst