-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split nusamai-mvt from nusamai repo #670
Conversation
Walkthroughこのプルリクエストでは、 Changes
Possibly related PRs
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
README.md (1)
121-121
: 新しい外部リポジトリリンクの追加を承認します。新しい外部リポジトリ
MIERUNE/tinymvt
へのリンクの追加は、PRの目的である「nusamai-mvtをnusamaiリポジトリから分離する」ことと一致しています。これは、MVT機能が別のリポジトリに移動されたことを示唆しており、プロジェクトの構造改善に貢献しています。ユーザーの理解を深めるために、このリンクの追加理由や
tinymvt
リポジトリとメインプロジェクトの関係について、簡単な説明を追加することを検討してください。例えば:- [MIERUNE/tinymvt](https://github.com/MIERUNE/tinymvt) — MVT生成のための小規模ユーティリティ。このプロジェクトから分離され、独立したリポジトリとして管理されています。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (2)
nusamai-mvt/Cargo.toml
is excluded by!**/*.toml
nusamai/Cargo.toml
is excluded by!**/*.toml
📒 Files selected for processing (10)
- README.md (1 hunks)
- nusamai-mvt/build.rs (0 hunks)
- nusamai-mvt/src/geometry.rs (0 hunks)
- nusamai-mvt/src/lib.rs (0 hunks)
- nusamai-mvt/src/tag.rs (0 hunks)
- nusamai-mvt/src/tileid/hilbert.rs (0 hunks)
- nusamai-mvt/src/tileid/mod.rs (0 hunks)
- nusamai-mvt/src/vector_tile.proto (0 hunks)
- nusamai-mvt/src/vector_tile.rs (0 hunks)
- nusamai-mvt/src/webmercator.rs (0 hunks)
💤 Files with no reviewable changes (9)
- nusamai-mvt/build.rs
- nusamai-mvt/src/geometry.rs
- nusamai-mvt/src/lib.rs
- nusamai-mvt/src/tag.rs
- nusamai-mvt/src/tileid/hilbert.rs
- nusamai-mvt/src/tileid/mod.rs
- nusamai-mvt/src/vector_tile.proto
- nusamai-mvt/src/vector_tile.rs
- nusamai-mvt/src/webmercator.rs
🧰 Additional context used
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files
📢 Thoughts on this report? Let us know! |
No description provided.