Use std::string instead of COW string

There is no much benefit from COW string since we have move semantics in ports and unique identifiers of instructions.
MIPT-ILab · Aug 30, 2018 · 51de9e1 · 51de9e1
1 parent e25c3d3
commit 51de9e1
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 266 deletions.
diff --git a/external/kryucow_string.h b/external/kryucow_string.h
diff --git a/simulator/mips/mips_instr.h b/simulator/mips/mips_instr.h
@@ -17,9 +17,6 @@
 #include <infra/string_view.h>
 #include <infra/types.h>
 
-// COW string
-#include <kryucow_string.h>
-
 // Generic C++
 #include <array>
 #include <unordered_map>
@@ -196,11 +193,8 @@ class BaseMIPSInstr
 
         uint64 sequence_id = NO_VAL64;
 
-#if 0
         std::string disasm = {};
-#else
-        KryuCowString disasm = {};
-#endif
+
         void init( const ISAEntry& entry, MIPSVersion version);
 
         // Predicate helpers - unary

diff --git a/simulator/risc_v/riscv_instr.h b/simulator/risc_v/riscv_instr.h
@@ -14,9 +14,6 @@
 #include <infra/string_view.h>
 #include <infra/types.h>
 
-// COW string
-#include <kryucow_string.h>
-
 // Generic C++
 #include <array>
 #include <unordered_map>
@@ -44,11 +41,7 @@ class RISCVInstr
 
         uint64 sequence_id = NO_VAL64;
 
-#if 0
         std::string disasm = {};
-#else
-        KryuCowString disasm = {};
-#endif
 
     public:
         RISCVInstr() = delete;