FIX: Slow startup and performance on NFS or slow volume mounts #188 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostefano
reviewed
Nov 29, 2024
| FILES_VERSION= | ||
| MISP_APP_FILES_PATH=/var/www/MISP/app/files | ||
| if [ -f ${MISP_APP_FILES_PATH}/VERSION ]; then | ||
| FILES_VERSION=$(cat ${MISP_APP_FILES_PATH}/VERSION) |
There was a problem hiding this comment.
Can you add a line echoing the parsed version?
There was a problem hiding this comment.
Ola Stefano, sure, but I messed up and used the master branch instead of an issue, and now it's all messed up -- I'm re-creating this PR with the echo and the right branch
Please ignore the other updates on this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #188
Adds a bit of documentation on how to enable a different
ATTACHMENTS_DIRand what other folders need to be mounted instead of the/var/www/MISP/app/files.Places the attachments folder outside of the
files/structure, that will remain basically the same as the distribution, with the exception offiles/img/andfiles/terms/, folders that should be affected by a NFS filesystem.During initialization, checks if the
files/folder was mounted before performing any tasks on it.