Skip to content

Commit

Permalink
Update REVIEW tag for MIT-CAVE/cave_static#507
Browse files Browse the repository at this point in the history
  • Loading branch information
luisvasq committed Nov 10, 2024
1 parent 776c893 commit d96433d
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions cave_api/cave_api/examples/kitchen_sink.py
Original file line number Diff line number Diff line change
Expand Up @@ -930,12 +930,14 @@ def execute_command(session_data, socket, command="init", **kwargs):
}
},
# REVIEW:
# Current implemented behavior on `cave_static`: `colorBy` and `sizeB`` dropdowns are populated with props
# Current implemented behavior on `cave_static`: `colorBy` and `sizeBy` dropdowns are populated with props
# that have at least one gradient/color or size range/option value after left-merging
# `legendGroups.lga.data.nodeTypeA.props` with `mapFeatures.data.nodeTypeA.props`.
# We could define a list of prop keys to specify which props should appear in the dropdowns by using
# `colorByOptions` and `sizeByOptions`. Note that `colorByOptions` and `sizeByOptions` are now different
# from the old structure and will only point to the keys.

# REVIEW: The following is not implemented yet:
# I think we could define a list of prop keys to specify which props should appear in the dropdowns by
# using `colorByOptions` and `sizeByOptions`. Note that `colorByOptions` and `sizeByOptions` would be
# different from the old structure and will only point to the keys.
"colorByOptions": [],
"sizeByOptions": [],
},
Expand Down

0 comments on commit d96433d

Please sign in to comment.