Allow selector items to specify an optional color for use in dropdowns/menues/map legend.

[connor-makowski]

This would override colorBy in the legend to not introduce a breaking change.

[luisvasq]

@connor-makowski, @mrkwanzaa: hey guys, when you have a chance, I'd love to hear your thoughts on the REVIEW tags on https://github.com/MIT-CAVE/cave_app/blob/d96433db64f35ba88838f87b2a2345c01c75c27a/cave_api/cave_api/examples/kitchen_sink.py.

[connor-makowski]

I actually like fallback quite a bit.

Breaking default into color and size: Not a huge fan, Ideally it would match the options object (which the current form does).

I am okay locking max and min to be the same for both color and size

Not sure if we should be overriding prop attributes in the legend. We can add that feature later if needed, but I think omitting it would provide a lot of clarity. This will also get messy for us if for example a user changed an icon in the legend, but the prop icon did not change in the prop. Maybe it should, maybe it shouldn't. The expected behavior there is a bit funky.

[connor-makowski]

Note: default / fallback should be specified in the prop itself..

[luisvasq]

Regarding overriding: I agree. Rather than a feature, I wanted to show where the new color and size values are placed when they're adjusted in the legend, to avoid locking color/size for different map features that share the same selected prop.

Not sure if we should be overriding prop attributes in the legend. We can add that feature later if needed, but I think omitting it would provide a lot of clarity. This will also get messy for us if for example a user changed an icon in the legend, but the prop icon did not change in the prop. Maybe it should, maybe it shouldn't. The expected behavior there is a bit funky.

[connor-makowski]

I think for now, I want any change in the legend to be handled in the prop itself. (all maps will update at the same time).

[luisvasq]

This issue has grown to include gradients in the map legend. However, the main task of displaying some color/size viz within props is still pending and will be handled in 3.1.x. I will keep this issue open to track that feature.