Skip to content

Commit

Permalink
Add more informative warning and remove to-do
Browse files Browse the repository at this point in the history
  • Loading branch information
ml-evs committed Sep 20, 2023
1 parent ec32ce5 commit c146744
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions tests/test_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,24 +178,26 @@ def test_q_sample_data(
assert len(tables) == 6

try:
# TODO: pin down why these values are different compared to the deployment
check_tables(
[td.text for td in tables[0].find_all("td")], sample_q_output
), "Output table failed"
except AssertionError:
warnings.warn("Output table did not match for echem data")
warnings.warn(
"Output table did not match for echem data, probably due to degeneracy in principal axes"
)

check_tables(
[td.text for td in tables[1].find_all("td")], sample_q_delta_length
), "% length failed"

try:
# TODO: pin down why these values are different compared to the deployment
check_tables(
[td.text for td in tables[2].find_all("td")], sample_q_principal_axes
), "Principal axes table failed"
except AssertionError:
warnings.warn("Output table did not match for echem data")
warnings.warn(
"Output table did not match for echem data, probably due to degeneracy in principal axes"
)

check_tables(
[td.text for td in tables[3].find_all("td")], sample_q_charge_derivative
Expand Down

0 comments on commit c146744

Please sign in to comment.