Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRK: handle level 91+ #434

Merged
merged 2 commits into from
Sep 11, 2024
Merged

DRK: handle level 91+ #434

merged 2 commits into from
Sep 11, 2024

Conversation

lhn1703
Copy link

@lhn1703 lhn1703 commented Aug 18, 2024

image

Handles #393

@kaedys
Copy link

kaedys commented Aug 18, 2024

So, one of the things I wanted to have as a suboption, probably for both of the new Disesteem features, is to whether to use the Scarlet Delirium combo first, or use Disesteem first. The Balance official rotation uses Disesteem first, but I suspect we'll want to default to using the Scarlet Delirium combo first, with a subfeature to prioritize Disesteem, purely because Disesteem has a 10y range and can thus be used to cover a GCD disconnect during those 4 GCDs (this assuming that it doesn't break the Delirium combo, though). Bonus points if we also throw an IsInMelee() check on the Delirium combo and fall back to Disesteem if we're out of melee.

@MKhayle
Copy link
Owner

MKhayle commented Sep 11, 2024

Let's go with this first and then break it down if required/improve it then

@MKhayle MKhayle merged commit 6b47ecd into MKhayle:master Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants