-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ability for user to add and view work experience #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please make sure the tests are passing before we approve this for merge?
This is pretty decent @citruscai , excellent job. My thoughts:
But overall you did a great job. Kudos! |
Agreed with @Kingscliq, @citruscai please look into these points |
thank you so much @Kingscliq @yashika51 !! will look into it! will hopefully have these fixes in by end of day |
@Kingscliq should i remove it from my committ? this article is suggesting to keep it in git and the only reason it was in my commit was because of the prettier formatting yarnpkg/yarn#1583 |
You can leave it. it's unopinionated. But I agree with the article for sharing consistent packages across projects |
Changes Made:
Made sure its passing all checks! should be good to go |
@yashika51 ok just fixed conflicts and workflow checks all passing now |
Good job! |
Fixes #11
Summary of Features:
1.
ExperienceForm
Component2.
ViewExperience
ComponentExperienceForm
in a table-like structure.