-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor IRJ parser for Menhir new error handling #240
Conversation
At the end, add the whole parserMessage generation, completeness check, automaton dump and graph… This parser is small enough that it’s not too costly.
The current architecture is kind of underwhelming. On the one hand I would find satisfying to merge the Yes, writing it I just realise that the second pass is called only on errors, so it doesn’t slow the interpreter in a right case. But I keep the question as my problem is more than both pass have a very distinct behaviour. The second pass prints on error output in all cases. So at the end, my proposition would be:
At the end, I feel like irj_checker could also almost be just a wrapper calling |
f85da8f
to
0cf7a76
Compare
0cf7a76
to
231dea9
Compare
I think we should slow the work on the json generator and focus on the polish on file validation to merge it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's merge!
As stated in #238, traditionnal error handling is deprecated in favor of a flexible approach using Menhir incremental API.
Close #238