-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/check available gateways from api #78
Draft
malmo-monei
wants to merge
12
commits into
master
Choose a base branch
from
fix/check-available-gateways-from-API
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
malmo-monei
commented
Dec 16, 2024
- Introduction of autoloader, remove part of hardcoded require of files
- Use of PSR folder structure, Standardized class names to follow consistent naming conventions
- Added PHP-DI as the dependency injection container to streamline dependency resolution.
- Implemented ContainerProvider as a singleton for global access to the DI container.
- Dynamically registered services and classes, including gateways and block support classes:
- Services: PaymentMethodsService, BlockSupportService
- Gateways: Automatically resolved WCGatewayMonei[PaymentMethod]
- Blocks: Automatically resolved Monei[PaymentMethod]BlocksSupport
- Improved scalability and maintainability by removing hardcoded instantiations and centralizing dependency management.
- Refactored existing code to resolve dependencies via the container.
- Implement repository to fetch payment method availability via API so checks are dynamically fetched based on merchant data
- Use the availability method in frontend admin, and both checkout pages
# Conflicts: # includes/MoneiBizumBlocksSupport.php # includes/MoneiMBWayBlocksSupport.php # includes/MoneiMultibancoBlocksSupport.php # includes/class-monei-cc-blocks.php # includes/payment-methods/class-wc-gateway-monei-cc.php
# Conflicts: # src/Gateways/Abstracts/WCMoneiPaymentGatewayHosted.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.