-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported python versions #64
Conversation
I haven't done any testing yet, but I can if desired. I am not sure if it's needed for these changes. I added a file in the |
@altheaden and I discussed that we will first try to update the GitHub Actions workflow to no longer use mamba/mambaforge and see if that fixes python 3.12. |
@altheaden, can you rebase this one now that I merged #65? |
a614aa1
to
eab1c11
Compare
@altheaden, I think something is still wrong with the workflow here. This step: pyremap/.github/workflows/build_workflow.yml Lines 91 to 95 in eab1c11
should use conda create like we do on mache:https://github.com/E3SM-Project/mache/blob/main/.github/workflows/build_workflow.yml#L96-L102 Could you see if you can make that change? I think using conda install is not behaving well.
|
eab1c11
to
5799998
Compare
@altheaden, I think we might be able to fix the current issues by removing these lines:
Despite the comment, this is no longer needed. |
5799998
to
2cb49ce
Compare
@xylar I assume you have already looked at the changes I made in the build workflow (to match mache's, minus the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, great! I think we're finally in business.
Yes, as I think we discussed, the |
Thanks for the hard work on this @altheaden! |
conda-forge
has recently dropped support for python 3.8 and gained support for python 3.12, so I am updated these versions in this PR.