Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a logo? #593

Closed
wants to merge 12 commits into from
Closed

Adding a logo? #593

wants to merge 12 commits into from

Conversation

jinghuazhao
Copy link
Contributor

@jinghuazhao jinghuazhao commented Feb 21, 2025

  • Create logo.svg with Grok & then favicons
  • Adding logo.svg to man/figures and favicons to pkgdown/
  • Relocate index.md to pkgdown/
  • Amend README.Rmd with the <img> tag pointing to the logo and knitr::knit it.
  • Updated docs/ with rebuilt pkgdown site.

This is simply an idea for you to consider -- so feel free to alter. An artist's impression is here, https://cambridge-ceu.github.io/TwoSampleMR/index.html.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.68%. Comparing base (2244af0) to head (24f86d6).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #593       +/-   ##
===========================================
- Coverage   48.80%   38.68%   -10.12%     
===========================================
  Files          31       31               
  Lines        5250     5250               
===========================================
- Hits         2562     2031      -531     
- Misses       2688     3219      +531     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jinghuazhao jinghuazhao changed the title Jhz: Adding a logo? Adding a logo? Feb 22, 2025
@remlapmot
Copy link
Contributor

Thanks but sorry I won't take this as is:

  • if you are trying to draw the MR DAG this is not correct. The MR DAG is the instrumental variable DAG and is as follows

CleanShot 2025-02-24 at 15 56 19@2x

  • Also as you can see from the repo we use a GitHub actions workflow to render the pkgdown site - which commits the website files onto the gh-pages branch - there was no need to commit the modified docs files to the working branch.

@remlapmot remlapmot closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants