-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated banded calculations and added an adaptive time evolution operator construction #232
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
==========================================
+ Coverage 65.70% 66.66% +0.95%
==========================================
Files 185 187 +2
Lines 10232 10207 -25
==========================================
+ Hits 6723 6804 +81
+ Misses 3509 3403 -106 ☔ View full report in Codecov by Sentry. |
src/trees/CornerOperatorTree.h
Outdated
*/ | ||
class CornerOperatorTree final : public OperatorTree { | ||
public: | ||
using OperatorTree::OperatorTree; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CornerOperatorTree() = default;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It creates a warning:
In file included from /Users/edi011/mrcpp/src/trees/CornerOperatorTree.cpp:26:
/Users/edi011/mrcpp/src/trees/CornerOperatorTree.h:44:5: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted]
CornerOperatorTree() = default;
^
/Users/edi011/mrcpp/src/trees/CornerOperatorTree.h:41:34: note: default constructor of 'CornerOperatorTree' is implicitly deleted because base class 'OperatorTree' has no default constructor
class CornerOperatorTree final : public OperatorTree {
^
/Users/edi011/mrcpp/src/trees/CornerOperatorTree.h:44:28: note: replace 'default' with 'delete'
CornerOperatorTree() = default;
^~~~~~~
delete
1 warning generated.
In file included from /Users/edi011/mrcpp/src/operators/TimeEvolutionOperator.cpp:46:
/Users/edi011/mrcpp/src/trees/CornerOperatorTree.h:44:5: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted]
CornerOperatorTree() = default;
^
/Users/edi011/mrcpp/src/trees/CornerOperatorTree.h:41:34: note: default constructor of 'CornerOperatorTree' is implicitly deleted because base class 'OperatorTree' has no default constructor
class CornerOperatorTree final : public OperatorTree {
^
/Users/edi011/mrcpp/src/trees/CornerOperatorTree.h:44:28: note: replace 'default' with 'delete'
CornerOperatorTree() = default;
^~~~~~~
delete
1 warning generated.
…width calculation is still there
Added a possibility of adaptive construction for time evolution. Improved its application by introducing corner matrices types to the code.
Algorithm based on the inheritance from ConvolutionOperator is fully optimised now. Further significant optimisation can only be achieved by inheriting from MWOperator instead, which demands a lot of coding and so left for the future work.
I may have a memory leak, since I did not manage to override the destructor ~CornerOperatorTree(). Please check it.
There is also a problem with updating printer values (norms of operator nodes and trees), please check it as well.