Fix DMDcoin#51: Add reentrancy protection to critical functions

MSalman6 · Jan 22, 2025 · ef95916 · ef95916
1 parent 7b6280f
commit ef95916
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/contracts/DiamondDao.sol b/contracts/DiamondDao.sol
@@ -199,7 +199,7 @@ contract DiamondDao is IDiamondDao, Initializable, ReentrancyGuardUpgradeable, V
         emit SetIsCoreContract(_add, isCore);
     }
 
-    function switchPhase() external {
+    function switchPhase() external nonReentrant {
         if (block.timestamp < daoPhase.end) {
             return;
         }
@@ -249,7 +249,7 @@ contract DiamondDao is IDiamondDao, Initializable, ReentrancyGuardUpgradeable, V
         string memory title,
         string memory description,
         string memory discussionUrl
-    ) external payable onlyPhase(Phase.Proposal) noUnfinalizedProposals {
+    ) external payable nonReentrant onlyPhase(Phase.Proposal) noUnfinalizedProposals {
         if (
             targets.length != values.length ||
             targets.length != calldatas.length ||
@@ -336,7 +336,7 @@ contract DiamondDao is IDiamondDao, Initializable, ReentrancyGuardUpgradeable, V
         emit SubmitVoteWithReason(voter, proposalId, _vote, reason);
     }
 
-    function finalize(uint256 proposalId) external exists(proposalId) {
+    function finalize(uint256 proposalId) external nonReentrant exists(proposalId) {
         _requireState(proposalId, ProposalState.VotingFinished);
 
         Proposal storage proposal = proposals[proposalId];