Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making team doors automatically close after opening. #1151

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Jo5629
Copy link
Contributor

@Jo5629 Jo5629 commented May 25, 2023

Add function so door moves after two seconds. Probably needs some reworking but it is a working robust version.

Add function so door moves after two seconds.
@farooqkz
Copy link
Contributor

As I stated in the relevant issue, I strongly disagree with this as a "sudden big change" for something very common in the game. Read the logs in #1073

@farooqkz
Copy link
Contributor

@Jo5629 Happy first PR to the CTF codebase :D

@Jo5629
Copy link
Contributor Author

Jo5629 commented May 26, 2023

  1. Fair enough. I see what you mean. It will throw off tons of the players that have been on the server for a bit, and it will get annoying to some of them.
  2. Thanks farooqkz for the shoutout of my first PR.

@farooqkz
Copy link
Contributor

  1. Fair enough. I see what you mean. It will throw off tons of the players that have been on the server for a bit, and it will get annoying to some of them.

    1. Thanks farooqkz for the shoutout of my first PR.

That's my opinion. And I am not the one making decisions.

@LoneWolfHT
Copy link
Member

Should probably do a poll for this

@LoneWolfHT
Copy link
Member

Since this is a setting (now?) it probably doesn't need a poll unless we want to make it a default

@Jo5629
Copy link
Contributor Author

Jo5629 commented Aug 10, 2024

Since this is a setting (now?) it probably doesn't need a poll unless we want to make it a default

Yeah I kinda forgot about this until a few days ago (I procrastinate a lot).
People were yelling at each other to close the doors and then I remembered this existed so I rewrote it. But it should be ready (I think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants