Bugfix: Remove default capitalization of first and lastname #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francois2metz
force-pushed
the
remove-default-capitalization
branch
from
ab565dc to
0e051ff
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, DossierFacile capitalize the first letter of each words in the firstname and the lastname. The way it's done doesn't give any way to the user to fix it as it's done when the forms are saved.
The default capitalization result to wrong case. For example my name is "de Metz". The "de" is written in lowercase. "Metz" has the first letter in uppercase. This come from previous centuries were there was "noble" people. Hopefully this system is no longer in place in France, but the way it's written persist.
There is a lot of different way to write names in the world. My proposal is to let people choose how they want to appear, without any update from the system.