Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code checking avec Ruff #1079

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Code checking avec Ruff #1079

merged 3 commits into from
Dec 18, 2023

Conversation

etchegom
Copy link
Contributor

@etchegom etchegom commented Dec 12, 2023 •
edited
Loading

@etchegom etchegom self-assigned this Dec 12, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7439 5676 76% 72% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
conventions/forms/convention_form_administration.py 100% 🟢
conventions/forms/convention_form_denonciation.py 100% 🟢
conventions/views/convention_form.py 97% 🟢
core/settings.py 81% 🟢
programmes/models/models.py 97% 🟢
siap/siap_client/client.py 51% 🟢
TOTAL 88% 🟢

updated for commit: 35603fe by action🐍

kolok
kolok approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nickel
Il faudra qu'on l'insert dans notre nouvelle config de CI

@syldb syldb changed the base branch from develop to main December 18, 2023 06:57
@etchegom etchegom force-pushed the ruff branch 2 times, most recently from 8332f72 to 49e1ecf Compare December 18, 2023 11:21
@etchegom etchegom changed the title 🚧 Ruff Ruff Dec 18, 2023
@etchegom etchegom marked this pull request as ready for review December 18, 2023 14:30
@etchegom etchegom requested a review from a team as a code owner December 18, 2023 14:30
@etchegom etchegom requested review from MarjolaineLB and syldb and removed request for a team December 18, 2023 14:30
@etchegom etchegom changed the title Ruff Code checking avec Ruff Dec 18, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@etchegom etchegom merged commit cc14d59 into main Dec 18, 2023
7 checks passed
@etchegom etchegom deleted the ruff branch December 18, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolok kolok kolok approved these changes

@MarjolaineLB MarjolaineLB MarjolaineLB approved these changes

@syldb syldb syldb approved these changes

Assignees

@etchegom etchegom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etchegom @kolok @MarjolaineLB @syldb