Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avenants tableau logements facultatif #1421

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

syldb
Copy link
Contributor

@syldb syldb commented May 14, 2024

  • write some tests

Si on valide un tableau de logement vide,
Dans le cadre d'un avenant :
Capture d’écran 2024-05-14 à 09 01 10
Et dans le cadre d'une convention :
Capture d’écran 2024-05-14 à 09 03 03

@syldb syldb requested a review from a team as a code owner May 14, 2024 07:04
@syldb syldb requested review from kolok and etchegom and removed request for a team May 14, 2024 07:04
Copy link

github-actions bot commented May 14, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7939 6515 82% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
conventions/forms/convention_form_logements.py 83% 🟢
conventions/services/logements.py 65% 🟢
TOTAL 74% 🟢

updated for commit: 86a1d87 by action🐍

@syldb syldb force-pushed the avenants-tableau-logements branch from 89d0048 to 3602152 Compare May 14, 2024 08:01
@kolok
Copy link
Collaborator

kolok commented May 15, 2024

On ne voulait pas faire la même chose pour les conventions ? Ça peut être utile quand on veut modifier une convention importé d'Ecoloweb

Si oui, Ça peut être fait dans une autre PR

@syldb
Copy link
Contributor Author

syldb commented May 16, 2024

Ah j'étais sûr qu'on avait parlé de limiter aux avenants, mais ça m'arrange de faire aussi pour les conventions ça simplifie un peu le code

@syldb syldb force-pushed the avenants-tableau-logements branch 3 times, most recently from d650521 to a96514a Compare May 16, 2024 07:57
Copy link
Collaborator

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P'tit remarque sur les erreurs optionel ou non !

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression que ce fichier est un relicat d'une autre PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oui en effet, c'est remove !

@syldb syldb force-pushed the avenants-tableau-logements branch from a96514a to 86a1d87 Compare May 22, 2024 06:56
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kolok kolok merged commit 9194461 into main May 27, 2024
8 checks passed
@kolok kolok deleted the avenants-tableau-logements branch May 27, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants