Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up pour réduire le nombre d'erreur #1688

Merged
merged 2 commits into from
Jan 2, 2025
Merged

clean up pour réduire le nombre d'erreur #1688

merged 2 commits into from
Jan 2, 2025

Conversation

kolok
Copy link
Collaborator

@kolok kolok commented Dec 12, 2024

Description succincte du problème résolu

Carte Airtable / Lien Mattermost : Titre

Description plus détaillée de l'intention, l'approche ou de l'implémentation (ce qui n’est pas visible directement en lisant le code)

Type de changement :

  • Bug fix
  • Nouvelle fonctionnalité
  • Mise à jour de la documentation
  • Refactoring de code (explication à retrouver dans la description)

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

Comment tester

En local / staging :

Copy link

github-actions bot commented Dec 12, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8351 6955 83% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
core/settings.py 82% 🟢
TOTAL 82% 🟢

updated for commit: 658762c by action🐍

@kolok kolok changed the title clean up pour éduire le nombre d'erreur clean up pour réduire le nombre d'erreur Dec 17, 2024
@@ -1,5 +1,5 @@
{% if not request|is_readonly %}
<button class="fr-btn fr-icon-arrow-right-s-line fr-btn--icon-right" {% if targetted_form %}form="{{ targetted_form }}"{% endif %}>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus utilisé

@@ -137,17 +137,17 @@ <h4>Agrément de gestionnaire ou agrément d'intermédiation</h4>
<p class="notes">
<em>Pour toutes les sections ci-dessous, vous avez la possibilité de renseigner les champs en saisissant les informations ou en téléversant des images.</em>
</p>
{% include "common/form/input_upload.html" with form_input=form.vendeur form_input_files=form.vendeur_files object_name='programme' object_uuid=convention.programme.uuid textarea=True image_only=True file_list=convention.programme.vendeur|get_files_from_textfiles object_field="programme__vendeur__"|add:form.uuid.value %}
{% include "common/form/input_upload.html" with single_file=False form_input=form.vendeur form_input_files=form.vendeur_files object_name='programme' object_uuid=convention.programme.uuid textarea=True image_only=True file_list=convention.programme.vendeur|get_files_from_textfiles object_field="programme__vendeur__"|add:form.uuid.value %}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evite un log en debug disant que single_file n'est pas défini

@kolok kolok marked this pull request as ready for review December 17, 2024 14:13
@kolok kolok requested a review from a team as a code owner December 17, 2024 14:13
@kolok kolok requested review from etchegom and syldb and removed request for a team December 17, 2024 14:13
Copy link
Contributor

@etchegom etchegom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolok kolok merged commit a23d787 into main Jan 2, 2025
9 checks passed
@kolok kolok deleted the clean_up_pr branch January 2, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants