Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

déterminer la natureLogement quand elle est null selon la natureOperation #1732

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

kolok
Copy link
Collaborator

@kolok kolok commented Feb 5, 2025

Description succincte du problème résolu

Pour que les conventions des sans financement soient du bon type

J'en ai profité pour passer les fonctions is_residence et is_foyer en property

N'oublier pas de taguer : bug, enhancement, documentation, technical, dependencies (+ escalation, regression si besion)

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

Comment tester

En local / staging :

@kolok kolok requested a review from a team as a code owner February 5, 2025 17:58
@kolok kolok requested review from etchegom and syldb and removed request for a team February 5, 2025 17:58
@kolok kolok added the enhancement New feature or request label Feb 5, 2025
@kolok kolok force-pushed the manage_nature_logement branch from c31b94d to f439a88 Compare February 6, 2025 05:36
Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link

github-actions bot commented Feb 6, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8547 7080 83% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
conventions/forms/convention_form_financement.py 85% 🟢
conventions/models/convention.py 88% 🟢
conventions/services/convention_generator.py 82% 🟢
conventions/services/financement.py 63% 🟢
conventions/tasks.py 81% 🟢
conventions/templatetags/custom_filters.py 79% 🟢
conventions/views/avenants.py 57% 🟢
conventions/views/convention_form.py 97% 🟢
programmes/models/choices.py 96% 🟢
programmes/models/models.py 97% 🟢
siap/siap_client/utils.py 71% 🟢
TOTAL 81% 🟢

updated for commit: 16f5b90 by action🐍

@kolok kolok merged commit 5d7ec92 into main Feb 7, 2025
9 checks passed
@kolok kolok deleted the manage_nature_logement branch February 7, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants