Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Suppression de ActivityListener #3629

Merged
merged 10 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions src/Command/ImportSignalementCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@
namespace App\Command;

use App\Entity\Territory;
use App\EventListener\ActivityListener;
use App\Service\Import\CsvParser;
use App\Service\Import\Signalement\SignalementImportLoader;
use App\Service\UploadHandlerService;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Events;
use Doctrine\ORM\NonUniqueResultException;
use League\Flysystem\FilesystemException;
use League\Flysystem\FilesystemOperator;
Expand Down Expand Up @@ -57,8 +55,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
return Command::FAILURE;
}

$this->removeEventListener();

$fromFile = 'csv/signalement_'.$territoryZip.'.csv';
$toFile = $this->parameterBag->get('uploads_tmp_dir').'signalement.csv';
if (!$this->fileStorage->fileExists($fromFile)) {
Expand Down Expand Up @@ -107,19 +103,4 @@ protected function execute(InputInterface $input, OutputInterface $output): int

return Command::SUCCESS;
}

private function removeEventListener(): void
{
$eventManager = $this->entityManager->getEventManager();

$eventsToCheck = [Events::onFlush, Events::preRemove];

foreach ($eventsToCheck as $event) {
foreach ($eventManager->getListeners($event) as $listener) {
if ($listener instanceof ActivityListener) {
$eventManager->removeEventListener([$event], $listener);
}
}
}
}
}
2 changes: 1 addition & 1 deletion src/Controller/Back/SignalementActionController.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public function addSuiviSignalement(

$this->addFlash('success', 'Suivi publié avec succès !');
} else {
$this->addFlash('error', 'Une erreur est survenue lors de la publication.');
$this->addFlash('error', 'Une erreur de jeton est survenue lors de la publication.');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai précisé cette erreur ici, parce qu'il y avait une erreur similaire juste au-dessus, et j'aime pas quand deux erreurs différentes retournent le même texte :)

}

return $this->redirect(
Expand Down
29 changes: 16 additions & 13 deletions src/DataFixtures/Loader/LoadSuiviData.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ public function load(ObjectManager $manager): void

$second = 1;
foreach ($signalements as $signalement) {
$createdAtUpdated = $signalement->getCreatedAt()->modify('+'.$second.' second');
$suivi = $this->suiviManager->createSuivi(
user: $this->userRepository->findOneBy(['email' => $this->parameterBag->get('user_system_email')]),
signalement: $signalement,
Expand All @@ -44,6 +43,7 @@ public function load(ObjectManager $manager): void
isPublic: true,
flush: false,
);
$createdAtUpdated = $signalement->getCreatedAt()->modify('+'.$second.' second');
$suivi->setCreatedAt($createdAtUpdated);
$manager->persist($suivi);
++$second;
Expand All @@ -63,20 +63,23 @@ public function load(ObjectManager $manager): void
public function loadSuivi(ObjectManager $manager, array $row): void
{
$signalement = $this->signalementRepository->findOneBy(['reference' => $row['signalement']]);
$createdBy = isset($row['created_by']) ? $this->userRepository->findOneBy(['email' => $row['created_by']]) : null;
$createdAt = new \DateTimeImmutable();
if (isset($row['created_at'])) {
$createdAt = new \DateTimeImmutable($row['created_at']);
} elseif (Suivi::TYPE_USAGER_POST_CLOTURE === $row['type']) {
$createdAt = $signalement->getClosedAt()->modify('+3 days');
}

$suivi = $this->suiviManager->createSuivi(
signalement : $signalement,
description : $row['description'],
type : $row['type'],
isPublic : $row['is_public'],
flush: false
);
$suivi->setCreatedAt(
isset($row['created_at']) ? new \DateTimeImmutable($row['created_at']) :
(Suivi::TYPE_USAGER_POST_CLOTURE === $row['type'] ? $signalement->getClosedAt()->modify('+3 days') : new \DateTimeImmutable())
signalement: $signalement,
description: $row['description'],
type: $row['type'],
isPublic: $row['is_public'],
user: $createdBy,
createdAt: $createdAt,
flush: false,
);
if (isset($row['created_by'])) {
$suivi->setCreatedBy($this->userRepository->findOneBy(['email' => $row['created_by']]));
}
$manager->persist($suivi);
}

Expand Down
20 changes: 20 additions & 0 deletions src/Event/SuiviCreatedEvent.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?php

namespace App\Event;

use App\Entity\Suivi;
use Symfony\Contracts\EventDispatcher\Event;

class SuiviCreatedEvent extends Event
{
public const NAME = 'suivi.created';

public function __construct(private Suivi $suivi)
{
}

public function getSuivi(): ?Suivi
{
return $this->suivi;
}
}
248 changes: 0 additions & 248 deletions src/EventListener/ActivityListener.php

This file was deleted.

Loading
Loading