Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package for Pypi #33

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Package for Pypi #33

wants to merge 6 commits into from

Conversation

ilesinge
Copy link

Implements #5

@ilesinge ilesinge marked this pull request as ready for review December 12, 2022 18:57
@ilesinge ilesinge mentioned this pull request Dec 12, 2022
Open
Bomme
Bomme reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@Bomme Bomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ilesinge for this PR!

pyproject.toml Outdated Show resolved Hide resolved
@ffont ffont changed the title Package with Poetry Package for Pypi Dec 19, 2022
@ffont
Copy link
Member

ffont commented Dec 19, 2022

Hi @Bomme @ilesinge , I was to merge that and go ahead with publishing but the workflow for testing the package fails. I tried to fix but I'm a bit confused. Sorry I don't have a lot of experience publishing in pypi, but:

  • The error seems to be related to packages = [{include = "freesound.py"}] not doing its job as it tries also to add the other files (the example and download_bookmarks_example).
  • If we're not using poetry now, why are there references to poetry in pyproject.otml? Is this something to be fixed?

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bomme Bomme Bomme left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilesinge @ffont @Bomme