-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solr 9 #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alastair
commented
Sep 20, 2022
alastair
commented
Sep 20, 2022
alastair
commented
Sep 20, 2022
alastair
commented
Sep 20, 2022
This was referenced Nov 9, 2022
Closed
alastair
force-pushed
the
solr9
branch
2 times, most recently
from
November 27, 2022 14:32
9507649
to
1ebff31
Compare
Merged
The new PointInteger field in solr doesn't support being used as a unique id field, so we switched id to a string. This requires casting it back to an int in a few places when using it to retrieve sounds from the database date fields can be a DatePoint or DateRange, the Range type is used for filtering within a range (e.g. created:[from TO to]), but the point field must be used for ordering, so we add the created field with both types and choose one depending on what we want to do.
Some sounds have the same tag multiple times, in upper and lower case. This has the result of boosting sounds with multiple tag instances higher in the search results (as solr sees that the term frequency is higher). In order to prevent this unfair boost, unique and lower-case all tags before adding to the index. This won't prevent boosting from occurring if a word appears multiple times in other search fields, such as description. (until we introduce the BooleanSimilarity)
Forum solr tests require this field
Specify all settings as query parameters instead of defaults
We're not interested in ranking based on field length or tf/idf of the search term, we only want to know if the term is in the field
Updating to sync with changes to the solr 5 core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new solr 9 core and removes the old solr 4 core
The new PointInteger field in solr doesn't support being used as
a unique id field, so we switched id to a string. This requires
casting it back to an int in a few places when using it to retrieve
sounds from the database
date fields can be a DatePoint or DateRange, the Range type is used
for filtering within a range (e.g. created:[from TO to]), but the
point field must be used for ordering, so we add the created field
with both types and choose one depending on what we want to do.
Still some experiments to be done on the search results and similarity types that we will use.
Checklist:
test_search_engine_backend
command forget_user_tags
methodtest_search_engine_backend
command forget_pack_tags
methodtest_search_engine_backend
to create a new core for running tests againstget_stream_sounds
(which also performs a search in solr) and refactor some parts of it if neededtest_search_engine_backend
scripts to test multiple-word queries.test_search_engine_backend
for geo queriesAND
instead ofOR
to replicate the default behaviour of solr < 5commitAfter
instead of always commit