Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodejs install did not install npm #1750

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Nodejs install did not install npm #1750

merged 2 commits into from
Jan 15, 2024

Conversation

Bomme
Copy link
Contributor

@Bomme Bomme commented Jan 7, 2024

Description
give preference to the nodesource repo when installing nodejs
since debian bookworm nodejs was installed from the debian repo and not
from the nodesource repo. This package did not require npm by default.
Using the installer script solves the issue.

See: nodesource/distributions#1725

Deployment steps:

Bomme added 2 commits January 7, 2024 22:44
since debian bookworm nodejs was installed from the debian repo and not
from the nodesource repo. This package did not require npm by default.
Using the installer script solves the issue
@Bomme Bomme requested review from alastair and ffont and removed request for alastair January 7, 2024 21:49
@alastair
Copy link
Member

alastair commented Jan 8, 2024

hahaha, what?
https://github.com/nodesource/distributions

Installation Scripts: Back by popular demand, the installation scripts have returned and are better than ever. See the installation instructions below for details on how to use them.

So.. they decided to remove the script (#1691), but now it's back? I have no idea. Happy to merge this if they recommend it again. Let's count down the days until they remove it again

@ffont
Copy link
Member

ffont commented Jan 11, 2024

Ahh, all node-related stuff is so frightening to me...
Did you try that with an image built with this you can install all static dependencies and build them?

@Bomme
Copy link
Contributor Author

Bomme commented Jan 12, 2024

yes, I could install and build.

The only thing that scared me was the --force in docker compose run --rm web npm install --force 😆

@Bomme
Copy link
Contributor Author

Bomme commented Jan 12, 2024

Alternatively we could remove the nodesource stuff and explicitly take the nodejs version from debian (currently 18.19.0) https://packages.debian.org/bookworm/nodejs

@ffont
Copy link
Member

ffont commented Jan 15, 2024

I like to specify the version so let's keep it how it is (after your change). Thanks!

@ffont ffont merged commit b42a07e into master Jan 15, 2024
1 check passed
@ffont ffont deleted the node_npm_install branch January 15, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants