make tag browsing case-insensitive and unique #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bomme
reviewed
Jan 13, 2025
| if multiple_tags: | ||
| multiple_tags = multiple_tags.split('/') | ||
| else: | ||
| multiple_tags = [] | ||
| multiple_tags = sorted([x for x in multiple_tags if x]) | ||
| #Make all tags lower-cased and unique to get a case-insensitive search filter and shortened browse url | ||
| multiple_tags = sorted(set([x.lower() for x in multiple_tags if x])) |
There was a problem hiding this comment.
No need to for the list comprehension if we turn it into a set anyways
Suggested change
| multiple_tags = sorted(set([x.lower() for x in multiple_tags if x])) | |
| multiple_tags = sorted({x.lower() for x in multiple_tags if x}) |
| @@ -152,7 +152,7 @@ def search_view_helper(request): | |||
| 'tags_mode': sqp.tags_mode_active(), | |||
| 'query_time': results.q_time | |||
| })) | |||
|
|
|||
There was a problem hiding this comment.
Nit pick: Consider setting your editor to trim all trailing whitespace automatically or use a code formatter
I think it's still possible to add both lower-case and upper-case tags when uploading a Sound or when changing a sounds description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
#1312
Description
In the
tagview, make the multiple_tags list elements to be lowercased and unique, in order to get a proper search_filterNote: I do not really understand why uppercase tags exist, other than by directly writing them into the url I have not found a way to use them in the Freesound website. However I guess this is still useful.