[lihui] #N/A refactor: fix code smell

MTWGA · Apr 5, 2024 · 71d983d · 71d983d
1 parent 3f08f6a
commit 71d983d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/client/TrelloClient.java b/src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/client/TrelloClient.java
@@ -67,6 +67,6 @@ public Card createCard(Card card) {
     public List<Label> getLabels() {
         return trelloApi.getBoardLabels(trelloConfiguration.getTrelloBoardId()).stream()
                 .filter(label -> StringUtils.isNotBlank(label.getName()))
-                .collect(Collectors.toList());
+                .toList();
     }
 }
diff --git a/...net/lihui/app/plugin/thoughtworkscodereviewtools/constant/TrelloRequestErrorConstant.java b/...net/lihui/app/plugin/thoughtworkscodereviewtools/constant/TrelloRequestErrorConstant.java
@@ -1,5 +1,9 @@
 package net.lihui.app.plugin.thoughtworkscodereviewtools.constant;
 
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
+
+@NoArgsConstructor(access= AccessLevel.PRIVATE)
 public class TrelloRequestErrorConstant {
     public static final String BOARD_ID_INVALID_ERROR_MESSAGE = "invalid id";
 

diff --git a/...a/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/CodeReviewFeedbackAction.java b/...a/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/CodeReviewFeedbackAction.java
@@ -13,6 +13,7 @@
 import net.lihui.app.plugin.thoughtworkscodereviewtools.ui.FeedbackContext;
 
 import static java.util.Objects.isNull;
+import static java.util.Objects.nonNull;
 import static net.lihui.app.plugin.thoughtworkscodereviewtools.constant.TrelloRequestErrorConstant.AUTHORIZED_FAILED_FILL_SETTING_NOTIFICATION;
 import static net.lihui.app.plugin.thoughtworkscodereviewtools.constant.TrelloRequestErrorConstant.BOARD_ID_INVALID_ERROR_MESSAGE;
 import static net.lihui.app.plugin.thoughtworkscodereviewtools.constant.TrelloRequestErrorConstant.INVALID_BOARD_ID_NOTIFICATION;
@@ -57,7 +58,7 @@ private void doAction(AnActionEvent actionEvent) {
 
     private void initCodeReviewBoardService() {
         TrelloConfiguration trelloConfiguration = TrelloState.getInstance().getState();
-        if (trelloConfiguration.isAnyBlank()) {
+        if (nonNull(trelloConfiguration) && trelloConfiguration.isAnyBlank()) {
             throw new BaseException(SET_UP_NOTIFICATION);
         }
         codeReviewBoardService = new CodeReviewBoardService(trelloConfiguration);

diff --git a/...gin/thoughtworkscodereviewtools/intellij/controller/TwCodeReviewSettingsConfigurable.java b/...gin/thoughtworkscodereviewtools/intellij/controller/TwCodeReviewSettingsConfigurable.java
@@ -14,6 +14,8 @@
 
 import javax.swing.*;
 
+import java.util.Objects;
+
 import static net.lihui.app.plugin.thoughtworkscodereviewtools.constant.TrelloRequestErrorConstant.AUTHORIZED_FAILED_FILL_SETTING_NOTIFICATION;
 import static net.lihui.app.plugin.thoughtworkscodereviewtools.constant.TrelloRequestErrorConstant.BOARD_ID_INVALID_ERROR_MESSAGE;
 import static net.lihui.app.plugin.thoughtworkscodereviewtools.constant.TrelloRequestErrorConstant.INVALID_BOARD_ID_NOTIFICATION;
@@ -51,7 +53,7 @@ public JComponent createComponent() {
     public boolean isModified() {
         TrelloConfiguration trelloConfiguration = TrelloState.getInstance().getState();
 
-        return !trelloConfiguration.equals(twCodeReviewSettingsComponent.getCurrentTrelloConfiguration());
+        return !Objects.equals(trelloConfiguration, twCodeReviewSettingsComponent.getCurrentTrelloConfiguration());
     }
 
     @Override