Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input scRNA-seq data, logo, make wording more general #815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thereidfleish
Copy link
Contributor

  1. Adds the ability to input scRNA-seq data into the Appyter
  2. Add logo
  3. Update wording to make the Appyter's function more broad (e.g., not just tumors)

Copy link
Collaborator

@u8sand u8sand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation succeeded but see my comment on versioning.

Other than that I'm just wondering, if we're changing it anyway, "input" could be misleading if the background is also input by the user (which is allowed). I was thinking "target" but that is a bit overloaded with the fact that we're screening for gene targets..

appyters/Tumor_Gene_Target_Screener/appyter.json Outdated Show resolved Hide resolved
@thereidfleish
Copy link
Contributor Author

hmm...i guess we could call it "foreground"? i don't really like that but i guess it's consistent with "background"...
or we could call them "expression vectors" like you say on the configuration page...

lmk what you think, and then i'll make a new commit with the new version number and any name changes we decide to make

@u8sand
Copy link
Collaborator

u8sand commented Aug 5, 2022

I guess input is fine.. feel free to just up the minor patch version, in any-case I likely won't merge this till after next week as to not sabotage someones' demo 🥲

@thereidfleish
Copy link
Contributor Author

I guess input is fine.. feel free to just up the minor patch version, in any-case I likely won't merge this till after next week as to not sabotage someones' demo 🥲

makes sense, i just updated the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants